🐛 Fix deprecation conditions showing install errors and improve condition semantics - #2296

Fixes deprecation conditions showing install errors instead of actual deprecation status.

Problems Fixed

1. Install errors leaked into deprecation conditions

When installation failed, the error appeared in ALL conditions including deprecation ones:

- type: PackageDeprecated
  status: "False"
  reason: Failed
  message: "validating bundle: dependency not supported"  # ❌ Wrong place!

Users couldn't tell if something was actually deprecated.

2. Wrong bundle checked during upgrades

When upgrading v1.0.0 → v1.0.1, deprecation showed v1.0.1's status even when the upgrade failed.

This violates Kubernetes convention: status must show actual state, not desired state.

Changes Made

What we do now

Key improvements

1. Install errors stay separate

   • Errors → Progressing and Installed conditions only
   • Deprecation → catalog data only (never errors)

2. Use installed bundle (not resolved)

   • Checks what's actually running
   • Follows Kubernetes "status = actual state" convention

3. Correct reason values

   • Deprecated → when True
   • DeprecationStatusUnknown → when Unknown
   • Absent → when no bundle installed (BundleDeprecated only)

Before/After Comparison

Examples

Example 1: Install Error (Bug #2008)

Before:

- type: Progressing
  status: "True"
  message: "validation failed: dependency not supported"
- type: PackageDeprecated
  status: "False"
  reason: Failed
  message: "validation failed: dependency not supported"  # ❌ Error leaked!

After:

- type: Progressing
  status: "True"
  message: "validation failed: dependency not supported"
# ✅ PackageDeprecated absent (error didn't leak!)

Example 2: Catalog Removed

Before:

- type: BundleDeprecated
  status: "False"              # ❌ Misleading: claims "not deprecated"
  reason: Failed

After:

- type: BundleDeprecated
  status: "Unknown"            # ✅ Honest: we can't check
  reason: DeprecationStatusUnknown
  message: "deprecation status unknown: catalog data unavailable"